Remove allocations in callbacks #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- split slack from variable explicitly - remove all allocations in callbacks
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
- Coverage 74.31% 74.29% -0.03%
==========================================
Files 38 38
Lines 3703 3727 +24
==========================================
+ Hits 2752 2769 +17
- Misses 951 958 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
frapac
force-pushed
the
fp/alloc_callbacks
branch
from
4e89350
to
dbef23c
Compare
sshin23
approved these changes
Oct 21, 2022
| x_nlpmodel = _madnlp_unsafe_wrap(x, get_nvar(nlp)) | ||
| hess_nlpmodel = _madnlp_unsafe_wrap(hess, get_nnzh(nlp.meta)) | ||
| scale = (get_minimize(nlp) ? one(T) : -one(T)) | ||
| scale *= (is_resto ? zero(T) : solver.obj_scale[]) |
There was a problem hiding this comment.
scale = is_resto ? zero(T) : get_minimize(nlp) ? one(T) : -one(T)
| @test n_allocs == 0 | ||
| n_allocs = @allocated MadNLP.eval_lag_hess_wrapper!(solver, kkt, x, solver.y) | ||
| @test n_allocs == 0 | ||
| end |
There was a problem hiding this comment.
this is nice! maybe in the future we can do it for the whole solver level
There was a problem hiding this comment.
I agree! we should at least apply the same test on the linear solver wrapper.
| @@ -7,6 +7,7 @@ Implement the [`AbstractReducedKKTSystem`](@ref) in sparse COO format. | |||
| """ | |||
| struct SparseKKTSystem{T, VT, MT} <: AbstractReducedKKTSystem{T, VT, MT} | |||
| hess::VT | |||
| jac_callback::VT | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrimalVectorabstraction to remove the need to use_madnlp_unsafe_wrapperx(without the slack)